test(cp): cover download progress edge cases#146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
No linked issue. This is from the recurring test-gap detection pass.
Background
Recent work added download progress reporting for large
rc cpdownloads. The existing tests covered the known-size threshold behavior, but two branches remained unasserted: downloads with unknown total size and output configurations that disable progress rendering.Root Cause
The helper intentionally avoids creating progress for unknown content length and relies on
OutputConfigto suppress visible progress bars when--no-progressis active. Without focused tests, those branches could regress during future transfer UI changes.Solution
Added two focused unit tests for
update_download_progress:no_progresscreates state for a large transfer but keeps the progress bar hiddenTest Status
cargo test -p rustfs-cli commands::cp::tests::test_download_progresscargo fmt --all --checkmake pre-commit